]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
st/scroll-bar: Remove pointless condition
authorFlorian Müllner <fmuellner@gnome.org>
Fri, 13 Aug 2021 02:06:24 +0000 (04:06 +0200)
committerFlorian Müllner <fmuellner@gnome.org>
Fri, 13 Aug 2021 13:16:54 +0000 (15:16 +0200)
Both branches are identical (which is correct - orientation or
text direction is irrelevant for the trough).

Spotted by coverity in CID 351261.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1950>

src/st/st-scroll-bar.c

index d4aa1762d386fdbafd31eb4cbc590f4218f4b408..f7188e8247186f08d32e2ca22ef875f1ae5d5568 100644 (file)
@@ -200,23 +200,11 @@ scroll_bar_allocate_children (StScrollBar           *bar,
 
   st_theme_node_get_content_box (theme_node, box, &content_box);
 
-  if (priv->vertical)
-    {
-      trough_box.x1 = content_box.x1;
-      trough_box.y1 = content_box.y1;
-      trough_box.x2 = content_box.x2;
-      trough_box.y2 = content_box.y2;
-      clutter_actor_allocate (priv->trough, &trough_box);
-    }
-  else
-    {
-      trough_box.x1 = content_box.x1;
-      trough_box.y1 = content_box.y1;
-      trough_box.x2 = content_box.x2;
-      trough_box.y2 = content_box.y2;
-      clutter_actor_allocate (priv->trough, &trough_box);
-    }
-
+  trough_box.x1 = content_box.x1;
+  trough_box.y1 = content_box.y1;
+  trough_box.x2 = content_box.x2;
+  trough_box.y2 = content_box.y2;
+  clutter_actor_allocate (priv->trough, &trough_box);
 
   if (priv->adjustment)
     {